[PATCH v2 1/1] nvme: use macro definitions for setting reservation values

Christoph Hellwig hch at lst.de
Fri Oct 28 01:31:27 PDT 2022


On Tue, Oct 25, 2022 at 05:09:21PM -0600, Keith Busch wrote:
> As far as naming them goes, if the only usage is its definition, then
> what's the point? If there's a use for a named enum somewhere else, then
> yah, that improves readability.

I think it is nice bit of documentation.  E.g. if the enum is for the
bits or value in a nvme filed naming it after that field can be handy.



More information about the Linux-nvme mailing list