[PATCH v2] nvme-tcp: send quota for nvme_tcp_send_all()

Daniel Wagner dwagner at suse.de
Wed Oct 26 00:13:40 PDT 2022


On Tue, Oct 25, 2022 at 04:46:07PM +0300, Sagi Grimberg wrote:
> Daniel, does adding cond_resched() make the system responsive again?

As it turns out I can't reproduce it anymore. Our test lab got
restructured and the cabling between machine changed (maybe even
different network switches, idk). Also the target got a firmware
update.

It looks more like the real problem was caused by the network
infrastructure than the host itself. And adding the additional delay in
the send path was just reducing the load which made the ssh session
working.

Given this, I don't think we currently need to touch this code. Though
the unbounded loop makes me a bit uneasy.



More information about the Linux-nvme mailing list