[PATCH] nvme: ignore starting sector while error logging for passthrough requests

Christoph Hellwig hch at lst.de
Tue Oct 18 07:45:35 PDT 2022


On Tue, Oct 18, 2022 at 03:48:57PM +0200, Pankaj Raghav wrote:
> The final consensus in Daniel's patch[1] seems to be adding an opt in to
> log error only for admin commands, and logging error for user IO commands
> will remain as is.

Hmm, is it?  I'd think even for I/O commands the opt in makes some
sense.

> In that case, should we reconsider this patch to avoid printing a garbage
> value ((sector_t)-1) while logging error for IO passthrough commands?

We should probably do this, but it should probably go along with the
opt-in for I/O commands.



More information about the Linux-nvme mailing list