答复: [PATCH v2] nvme: fix memleak in nvme_ctrl_dhchap_secret_store()

zhangqilong zhangqilong3 at huawei.com
Tue Nov 29 19:49:30 PST 2022


> 
> On Tue, Nov 29, 2022 at 09:47:25AM +0100, Christoph Hellwig wrote:
> > Thanks,
> >
> > applied to nvme-6.1.
> 
> And I had to fix it to actually pass all the correct paramters to kmemdup, so it
> looks like this code wasn't even compile test.
> 
Oh, 

     It seems that I forget to do it for V2 version. I am sorry to it, It is so nice that you fix it.

> Btw, how can nvme_ctrl_dhchap_secret_store work without any kind of
> locking?

You means it should need a lock to avoid race condition?

Thanks!


More information about the Linux-nvme mailing list