[PATCH] tests/nvme: Remove test output for passthrough error logging

Chaitanya Kulkarni chaitanyak at nvidia.com
Wed Nov 16 10:41:13 PST 2022


>
>>> I confirmed the fix avoids the failure with v6.1-rc5 kernel. Also, I observe
>>> this fix makes the test case fail with v6.0 kernel. I suggest to skip the test
>>> case with kernel v6.0 or older, applying the hunk below. Could you repost v2
>>> with this change? Or if you want, I can apply it together with v1. Please let
>>> me know your preference.
>>
>> It sounds like some future case might allow these errors to log in some
>> circumstances, so I'm not sure the test case should be so dependent on
>> seeing or not seeing these messages. Is there a mechanism to say these
>> are optional messages that may or may not show up?
> 
> We could just remove the tests for now which would also work for pre-6.1 and add them back
> when the future case shows up (Hopefully soon - I’m working on it).  The test will be changed
> to test the opted-in and opted-out mechanism.
> 

This seems to be the right thing to add the testcase with right feature
upstream than fixing the broken testcase creating compatibility issues.

-ck



More information about the Linux-nvme mailing list