[PATCH 07/14] nvme: split nvme_kill_queues

Chaitanya Kulkarni chaitanyak at nvidia.com
Tue Nov 1 18:25:33 PDT 2022


On 11/1/22 08:00, Christoph Hellwig wrote:
> nvme_kill_queues does two things:
> 
>   1) mark the gendisk of all namespaces dead
>   2) unquiesce all I/O queues
> 
> These used to be be intertwined due to block layer issues, but aren't
> any more.  So move the unquiscing of the I/O queues into the callers,
> and rename the rest of the function to the now more descriptive
> nvme_mark_namespaces_dead.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
> ---
>   drivers/nvme/host/apple.c |  3 ++-
>   drivers/nvme/host/core.c  | 36 ++++++++----------------------------
>   drivers/nvme/host/nvme.h  |  3 +--
>   drivers/nvme/host/pci.c   |  6 ++++--
>   4 files changed, 15 insertions(+), 33 deletions(-)
> 

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>






More information about the Linux-nvme mailing list