[PATCH] nvme: set non-mdts limits at I/O queue creation

Keith Busch kbusch at kernel.org
Tue May 17 15:58:22 PDT 2022


On Tue, May 17, 2022 at 10:49:21PM +0000, Chaitanya Kulkarni wrote:
> On 5/17/22 15:44, Keith Busch wrote:
> > On Tue, May 17, 2022 at 10:41:54PM +0000, Chaitanya Kulkarni wrote:
> >> Also, this patch groups reading ctrl non-mdts limits right before I/O
> >> queue allocation for each transport, since these limits are only
> >> used for I/O queue allocation.
> > 
> > Maybe just check that 'ctrl->cntrltype == NVME_CTRL_IO' instead?
> 
> I did that initially, but if I remember correctly versions prior to
> 1.4 don't necessarily report a valid ctrl type.

I guess we could assume IO controller if < 1.4 since those are the only type
that could have existed.

Otherwise, I really don't like having this all be transport specific. It sounds
like updating the non_mdts limits could safely be done in scan_work since it
requires an IO tagset.



More information about the Linux-nvme mailing list