(2) [PATCH] nvme: allow duplicate NSIDs for the private namespaces

[Sungup Moon]

That was a typing error. unique is ok.

Thankyou!
 
 
--------- Original Message ---------
Sender : Pankaj Raghav <pankydev8 at gmail.com>
Date : 2022-03-28 14:34 (GMT+9)
Title : Re: [PATCH] nvme: allow duplicate NSIDs for the private namespaces
 
On Thu, Mar 24, 2022 at 04:43:14PM +0100, Christoph Hellwig wrote:
> From: Sungup Moon <sungup.moon at samsung.com>
> 
> +
> +/*
> + * NSID shall be unique for all shared namespaces, or if at least one of the
> + * following conditions is met:
> + *   1. Namespace Management is supported by the controller
> + *   2. ANA is supported by the controller
> + *   3. NVM Set are supported by the controller
> + *
> + * In other case, private namespace are not required to report a unique NSID.
> + */
> +static inline bool nvme_is_uniqueue_nsid(struct nvme_ctrl *ctrl,
> +                struct nvme_ns_head *head)
Is it s/uniqueue/unique/ ?
> +{
> +        return head->shared ||
> +                (ctrl->oacs & NVME_CTRL_OACS_NS_MNGT_SUPP) ||
> +                (ctrl->subsys->cmic & NVME_CTRL_CMIC_ANA) ||
> +                (ctrl->ctratt & NVME_CTRL_CTRATT_NVM_SETS);
> +}
> +
>