[PATCH 2/3] nvmet: restrict setting of discovery_nqn to discovery subsystem

John Meneghini jmeneghi at redhat.com
Wed Mar 23 17:52:09 PDT 2022


On 3/15/22 05:00, Christoph Hellwig wrote:
> On Tue, Mar 15, 2022 at 10:57:35AM +0200, Sagi Grimberg wrote:
>>> It is a fairly recent addition by you and without nvmetcli support, so
>>> maybe we can revert this entire attribute to redo discovery controller
>>> handling, but as-is this patch seems rather broken.
>>
>> I think we could, I doubt anyone uses this interface at this point...
> 
> Then please send a revert for "nvmet: make discovery NQN configurable"
> against the 5.17 tree ASAP.  That way it will only be in 5.16.

Has this patch been reverted yet?

I don't see the revert.

jmeneghi:centos-stream-9(nvme-5.18) > git logl -200 --grep="nvmet: make discovery NQN configurable"
626851e9225d 2021-10-20 1632292519  nvmet: make discovery NQN configurable [ Christoph Hellwig / hare at suse.de ]
jmeneghi:centos-stream-9(nvme-5.18) > git branch --contains 626851e9225d
   5.17/scsi-queue
   5.17/scsi-staging
   master
   nvme-5.17
* nvme-5.18








More information about the Linux-nvme mailing list