[PATCH v2] nvme: Fix CRMS masks for TP4084 - Time-to-ready

Keith Busch kbusch at kernel.org
Mon Jun 20 08:33:35 PDT 2022


On Mon, Jun 20, 2022 at 02:08:42PM +0200, Joel Granados wrote:
> Adjust the values of NVME_CAP_CRMS_CRIMS and NVME_CAP_CRMS_CRWMS masks as
> they are different from the ones in TP4084 - Time-to-ready.
> 
> Fixes: 354201c53e61 ("nvme: add support for TP4084 - Time-to-Ready Enhancements").
> 
> Signed-off-by: Joel Granados <j.granados at samsung.com>
> ---
>  include/linux/nvme.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 29ec3e3481ff..bbe8b03e7452 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -233,8 +233,8 @@ enum {
>  };
>  
>  enum {
> -	NVME_CAP_CRMS_CRIMS	= 1ULL << 59,
> -	NVME_CAP_CRMS_CRWMS	= 1ULL << 60,
> +	NVME_CAP_CRMS_CRIMS	= 1ULL << 60,
> +	NVME_CAP_CRMS_CRWMS	= 1ULL << 59,
>  };

Oops, thanks for the catch. Could you just rearrange them so they appear in
ascending order?



More information about the Linux-nvme mailing list