[PATCH] nvme: add device name to warning in uuid_show()

Keith Busch kbusch at kernel.org
Tue Jun 7 09:11:53 PDT 2022


On Tue, Jun 07, 2022 at 05:55:55PM +0200, Thomas Weißschuh wrote:
>  	if (uuid_is_null(&ids->uuid)) {
> -		printk_ratelimited(KERN_WARNING
> -				   "No UUID available providing old NGUID\n");
> +		dev_warn_ratelimited(dev, "No UUID available providing old NGUID\n");
>  		return sysfs_emit(buf, "%pU\n", ids->nguid);

The line split was correct to prevent this overly long line. But otherwise,
this looks good, though I'm wondering why this needs to be printed every time
someone reads the attribute.



More information about the Linux-nvme mailing list