[PATCH] nvme: add bug report info for global duplicate id

Christoph Hellwig hch at lst.de
Tue Jun 7 03:15:26 PDT 2022


On Mon, Jun 06, 2022 at 09:40:47AM -0700, Keith Busch wrote:
>  	if (ret) {
> +		struct nvme_subsystem *subsys = ctrl->subsys;
> +
>  		dev_err(ctrl->device,
>  			"globally duplicate IDs for nsid %d\n", nsid);
> +		dev_err(ctrl->device,
> +			"bug report info: VID:%04x model:%.*s firmware:%.*s\n",
> +			subsys->vendor_id,
> +			nvme_str_len(subsys->model, sizeof(subsys->model)),
> +			subsys->model,
> +			nvme_str_len(subsys->firmware_rev,
> +				     sizeof(subsys->firmware_rev)),
> +			subsys->firmware_rev);

So I like the idea here, but this won't give us the PCI device id
that we usually need for quirks.



More information about the Linux-nvme mailing list