[PATCH V4 1/1] nvme: Add verbose error logging

[Alan Adamson]

Thanks for all the feedback.  I think the patch evolved nicely.

Alan

> On Jan 24, 2022, at 12:20 PM, Keith Busch <kbusch at kernel.org> wrote:
> 
> On Mon, Jan 24, 2022 at 10:51:44AM -0800, Alan Adamson wrote:
>> Improves logging of NVMe errors.  If NVME_VERBOSE_ERRORS is configured,
>> a verbose description of the error is logged, otherwise only status codes/bits
>> is logged.
>> 
>> Verbose logging examples:
>> [  183.333734] nvme0n1: Read(0x2) @ LBA 0, 1 blocks, Unrecovered Read Error (sct 0x2 / sc 0x81) DNR
>> 
>> [  227.767945] nvme0: Activate Firmware(0x10), Invalid Field in Command (sct 0x0 / sc 0x2) DNR
>> 
>> Non-verbose logging examples:
>> [   41.280509] nvme0n1: I/O Cmd(0x2) @ LBA 0, 1 blocks, I/O Error (sct 0x2 / sc 0x81) DNR
>> 
>> [   77.249153] nvme0: Admin Cmd(0x10), I/O Error (sct 0x0 / sc 0x2) DNR
>> 
>> Signed-off-by: Martin K. Petersen <martin.petersen at oracle.com>
>> Signed-off-by: Alan Adamson <alan.adamson at oracle.com>
>> Reviewed-by: Himanshu Madhani <himanshu.madhani at oracle.com>
> 
> Looks good to me.
> 
> Reviewed-by: Keith Busch <kbusch at kernel.org>