[PATCH blktests 0/3] tetss/nvme: fix nvme disc changes

Sagi Grimberg sagi at grimberg.me
Wed Jan 12 14:06:14 PST 2022


> Sagi,
> 
> On 1/12/22 12:38 AM, Sagi Grimberg wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> What is preventing this to break again?
>>
>> Can we modify the tests to not rely on a consistent
>> output here. Perhaps just search/match the expected nvm subsystems
>> in the log page?
> 
> Do we expect to change the output of the log page again ?

Yes, I don't expect that we will lock down the discovery output
in both the target and nvme-cli.

> It is important to match the disc subsysnqn i.e.
> "nqn.2014-08.org.nvmexpress.discovery" and gencounter,
> only matching the nvm subsystems not going to get us good
> coverage.

I'm just saying that it is not sustainable. Nothing prevents
anyone from changing the log page again.



More information about the Linux-nvme mailing list