[PATCH 2/2] nvme: also mark passthrough-only namespaces ready in nvme_update_ns_info

[Christoph Hellwig]

On Wed, Feb 16, 2022 at 03:57:37PM +0100, Daniel Wagner wrote:
> On Wed, Feb 16, 2022 at 03:12:20PM +0100, Christoph Hellwig wrote:
> >  out_unfreeze:
> > -	blk_mq_unfreeze_queue(ns->disk->queue);
> > -out:
> >  	/*
> >  	 * If probing fails due an unsupported feature, hide the block device,
> >  	 * but still allow other access.
> >  	 */
> >  	if (ret == -ENODEV) {
> >  		ns->disk->flags |= GENHD_FL_HIDDEN;
> > +		set_bit(NVME_NS_READY, &ns->flags);
> >  		ret = 0;
> >  	}
> > +	blk_mq_unfreeze_queue(ns->disk->queue);
> 
> Do you want to unfreeze the queue also for non ENODEV errors? It seems
> ENOMEM is possible.

We always want to unfreeze it, just as before.  The unfreeze just moves
after the place where we set NVME_NS_READY.