[PATCH v2 07/10] nvmet: add copy command support for bdev and file ns
kernel test robot
lkp at intel.com
Thu Feb 10 00:31:10 PST 2022
Hi Nitesh,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v5.17-rc3 next-20220209]
[cannot apply to device-mapper-dm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nitesh-Shetty/block-make-bio_map_kern-non-static/20220207-231407
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: arm64-randconfig-s032-20220207 (https://download.01.org/0day-ci/archive/20220210/202202101647.VtWTgalm-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/6bb6ea64499e1ac27975e79bb2eee89f07861893
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nitesh-Shetty/block-make-bio_map_kern-non-static/20220207-231407
git checkout 6bb6ea64499e1ac27975e79bb2eee89f07861893
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/nvme/target/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/target/io-cmd-bdev.c:52:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] mcl @@ got restricted __le64 [usertype] @@
drivers/nvme/target/io-cmd-bdev.c:52:25: sparse: expected restricted __le32 [usertype] mcl
drivers/nvme/target/io-cmd-bdev.c:52:25: sparse: got restricted __le64 [usertype]
>> drivers/nvme/target/io-cmd-bdev.c:53:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] mssrl @@ got restricted __le32 [usertype] @@
drivers/nvme/target/io-cmd-bdev.c:53:27: sparse: expected restricted __le16 [usertype] mssrl
drivers/nvme/target/io-cmd-bdev.c:53:27: sparse: got restricted __le32 [usertype]
>> drivers/nvme/target/io-cmd-bdev.c:55:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] msrc @@ got restricted __le16 @@
drivers/nvme/target/io-cmd-bdev.c:55:26: sparse: expected unsigned char [usertype] msrc
drivers/nvme/target/io-cmd-bdev.c:55:26: sparse: got restricted __le16
drivers/nvme/target/io-cmd-bdev.c:58:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] msrc @@ got restricted __le16 @@
drivers/nvme/target/io-cmd-bdev.c:58:34: sparse: expected unsigned char [usertype] msrc
drivers/nvme/target/io-cmd-bdev.c:58:34: sparse: got restricted __le16
drivers/nvme/target/io-cmd-bdev.c:59:35: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] mssrl @@ got restricted __le32 [usertype] @@
drivers/nvme/target/io-cmd-bdev.c:59:35: sparse: expected restricted __le16 [usertype] mssrl
drivers/nvme/target/io-cmd-bdev.c:59:35: sparse: got restricted __le32 [usertype]
>> drivers/nvme/target/io-cmd-bdev.c:61:35: sparse: sparse: cast to restricted __le32
>> drivers/nvme/target/io-cmd-bdev.c:61:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:61:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] mcl @@ got restricted __le64 [usertype] @@
drivers/nvme/target/io-cmd-bdev.c:61:33: sparse: expected restricted __le32 [usertype] mcl
drivers/nvme/target/io-cmd-bdev.c:61:33: sparse: got restricted __le64 [usertype]
drivers/nvme/target/io-cmd-bdev.c:65:34: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] msrc @@ got restricted __le16 @@
drivers/nvme/target/io-cmd-bdev.c:65:34: sparse: expected unsigned char [usertype] msrc
drivers/nvme/target/io-cmd-bdev.c:65:34: sparse: got restricted __le16
drivers/nvme/target/io-cmd-bdev.c:66:35: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] mssrl @@ got restricted __le32 [usertype] @@
drivers/nvme/target/io-cmd-bdev.c:66:35: sparse: expected restricted __le16 [usertype] mssrl
drivers/nvme/target/io-cmd-bdev.c:66:35: sparse: got restricted __le32 [usertype]
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast to restricted __le32
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast to restricted __le32
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast to restricted __le32
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast to restricted __le32
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast to restricted __le32
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast to restricted __le32
drivers/nvme/target/io-cmd-bdev.c:68:35: sparse: sparse: cast from restricted __le16
drivers/nvme/target/io-cmd-bdev.c:68:33: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] mcl @@ got restricted __le64 [usertype] @@
drivers/nvme/target/io-cmd-bdev.c:68:33: sparse: expected restricted __le32 [usertype] mcl
drivers/nvme/target/io-cmd-bdev.c:68:33: sparse: got restricted __le64 [usertype]
--
>> drivers/nvme/target/admin-cmd.c:533:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned char [usertype] msrc @@ got restricted __le16 @@
drivers/nvme/target/admin-cmd.c:533:26: sparse: expected unsigned char [usertype] msrc
drivers/nvme/target/admin-cmd.c:533:26: sparse: got restricted __le16
>> drivers/nvme/target/admin-cmd.c:534:27: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] mssrl @@ got restricted __le32 [usertype] @@
drivers/nvme/target/admin-cmd.c:534:27: sparse: expected restricted __le16 [usertype] mssrl
drivers/nvme/target/admin-cmd.c:534:27: sparse: got restricted __le32 [usertype]
>> drivers/nvme/target/admin-cmd.c:535:27: sparse: sparse: cast to restricted __le32
>> drivers/nvme/target/admin-cmd.c:535:27: sparse: sparse: cast from restricted __le16
>> drivers/nvme/target/admin-cmd.c:535:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [usertype] mcl @@ got restricted __le64 [usertype] @@
drivers/nvme/target/admin-cmd.c:535:25: sparse: expected restricted __le32 [usertype] mcl
drivers/nvme/target/admin-cmd.c:535:25: sparse: got restricted __le64 [usertype]
vim +52 drivers/nvme/target/io-cmd-bdev.c
11
12 void nvmet_bdev_set_limits(struct block_device *bdev, struct nvme_id_ns *id)
13 {
14 const struct queue_limits *ql = &bdev_get_queue(bdev)->limits;
15 /* Number of logical blocks per physical block. */
16 const u32 lpp = ql->physical_block_size / ql->logical_block_size;
17 /* Logical blocks per physical block, 0's based. */
18 const __le16 lpp0b = to0based(lpp);
19
20 /*
21 * For NVMe 1.2 and later, bit 1 indicates that the fields NAWUN,
22 * NAWUPF, and NACWU are defined for this namespace and should be
23 * used by the host for this namespace instead of the AWUN, AWUPF,
24 * and ACWU fields in the Identify Controller data structure. If
25 * any of these fields are zero that means that the corresponding
26 * field from the identify controller data structure should be used.
27 */
28 id->nsfeat |= 1 << 1;
29 id->nawun = lpp0b;
30 id->nawupf = lpp0b;
31 id->nacwu = lpp0b;
32
33 /*
34 * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and
35 * NOWS are defined for this namespace and should be used by
36 * the host for I/O optimization.
37 */
38 id->nsfeat |= 1 << 4;
39 /* NPWG = Namespace Preferred Write Granularity. 0's based */
40 id->npwg = lpp0b;
41 /* NPWA = Namespace Preferred Write Alignment. 0's based */
42 id->npwa = id->npwg;
43 /* NPDG = Namespace Preferred Deallocate Granularity. 0's based */
44 id->npdg = to0based(ql->discard_granularity / ql->logical_block_size);
45 /* NPDG = Namespace Preferred Deallocate Alignment */
46 id->npda = id->npdg;
47 /* NOWS = Namespace Optimal Write Size */
48 id->nows = to0based(ql->io_opt / ql->logical_block_size);
49
50 /*Copy limits*/
51 if (ql->max_copy_sectors) {
> 52 id->mcl = cpu_to_le64((ql->max_copy_sectors << 9) / ql->logical_block_size);
> 53 id->mssrl = cpu_to_le32((ql->max_copy_range_sectors << 9) /
54 ql->logical_block_size);
> 55 id->msrc = to0based(ql->max_copy_nr_ranges);
56 } else {
57 if (ql->zoned == BLK_ZONED_NONE) {
58 id->msrc = to0based(BIO_MAX_VECS);
59 id->mssrl = cpu_to_le32(
60 (BIO_MAX_VECS << PAGE_SHIFT) / ql->logical_block_size);
> 61 id->mcl = cpu_to_le64(le32_to_cpu(id->mssrl) * BIO_MAX_VECS);
62 #ifdef CONFIG_BLK_DEV_ZONED
63 } else {
64 /* TODO: get right values for zoned device */
65 id->msrc = to0based(BIO_MAX_VECS);
66 id->mssrl = cpu_to_le32(min((BIO_MAX_VECS << PAGE_SHIFT),
67 ql->chunk_sectors) / ql->logical_block_size);
68 id->mcl = cpu_to_le64(min(le32_to_cpu(id->mssrl) * BIO_MAX_VECS,
69 ql->chunk_sectors));
70 #endif
71 }
72 }
73 }
74
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
More information about the Linux-nvme
mailing list