[PATCH v3 0/3] Handle number of queue changes

James Smart jsmart2021 at gmail.com
Mon Aug 29 11:56:55 PDT 2022


On 8/29/2022 2:07 AM, Hannes Reinecke wrote:
> On 8/29/22 10:38, Daniel Wagner wrote:
>> Updated this series to a proper patch series with Hannes and Sagi's
>> feedback addressed.
>>
>> I tested this with nvme-tcp but due to lack of hardware the nvme-rdma
>> is only compile tested.
>>
> 
> One does wonder: what about FC?
> Does it suffer from the same problems?
> 
> Cheers,
> 
> Hannes


Yep, wondering too. I don't think so... FC does do this differently.

We don't realloc io queues nor tag_sets.  We reuse the allocations and 
tag_set originally created in the 1st successful association for the 
controller.

On reconnect, we set the queue count, then call 
blk_mq_update_nr_hw_queues() if it changed before we get into the loops 
to change queue states.

So FC's call to update nr_hw_queues() is much earlier than rdma/tcp today.

-- james




More information about the Linux-nvme mailing list