[PATCH v2 2/3] nvme-tcp: Handle number of queue changes

[Daniel Wagner]

On Sun, Aug 28, 2022 at 03:25:09PM +0300, Sagi Grimberg wrote:
> > -static int nvme_tcp_configure_io_queues(struct nvme_ctrl *ctrl, bool new)
> > +static int nvme_tcp_configure_io_queues(struct nvme_ctrl *nctrl, bool new)
> 
> Lets not change the name here, it creates some churn...

Sure thing

> 
> >   {
> > -	int ret;
> > +	struct nvme_tcp_ctrl *ctrl = to_tcp_ctrl(nctrl);
> 
> Why do you need the tcp ctrl?

Because I was blind and didn't see ctrl->tagset ...

> > +	if (ret)
> > +		goto out_cleanup_connect_q;
> 
> You need to go to out_wait_freeze_timed_out as IOs pending have
> possibly restarted with nvme_unfreeze...

Copy & paste error.

Thanks for reviewing!
Daniel