[PATCH] nvme: don't flush scan work with non-idle request

Keith Busch kbusch at kernel.org
Wed Aug 17 08:07:56 PDT 2022


On Wed, Aug 17, 2022 at 01:29:37PM +0300, Sagi Grimberg wrote:
> 
> > > +
> > > +    /*
> > > +     * Ensure the namespace inventory is up-to-date before returning if
> > > +     * this command can change it.
> > > +     */
> > > +    if (ret >= 0 && effects & (NVME_CMD_EFFECTS_NIC |
> > > NVME_CMD_EFFECTS_NCC))
> > > +        flush_work(&ctrl->scan_work);
> > Maybe it is better to move nvme_queue_scan together here.
> 
> I agree, why not move the scan here as well?

Then I'd need to duplicate this to nvmet_passthru_execute_cmd_work(), and I
didn't want to do that. :)



More information about the Linux-nvme mailing list