[PATCH] nvme: have nvme_setup_rw return BLK_STS_OK

Christoph Hellwig hch at infradead.org
Thu Apr 28 08:07:53 PDT 2022


On Mon, Apr 18, 2022 at 07:43:50PM +0000, Vincent Fu wrote:
> Return BLK_STS_OK instead of 0 on success. Since BLK_STS_OK is defined
> as 0 this patch results in no functional change but to avoid confusion
> and to be consistent with nvme_setup_write_zeroes as well as
> nvme_setup_discard we should have nvme_setup_rw also return BLK_STS_OK.

I really don't see the point.  blk_status_t like all __bitwise types
is designed to be able to cope with a plain 0 just fine.



More information about the Linux-nvme mailing list