[PATCH] nvme-core: mark passthru requests RQF_QUIET flag

Sagi Grimberg sagi at grimberg.me
Thu Apr 7 04:52:50 PDT 2022


>> Using RQF_QUIET or blk_rq_is_passrhrough() will mean no nvme admin-passthru command will log an error.
>> I ran into this using the blktests I’m coding up for verbose errors.  Is this the behavior we want?
> 
> Well, you submitted the logging so we're curious about your use case.
> SCSI skips logging errors for internally submitted commands, but not for
> userspace passthrough.  So we could move the RQF_QUIET into
> __nvme_submit_sync_cmd / nvme_keep_alive_work / nvme_timeout / etc.
> 

Makes sense to me



More information about the Linux-nvme mailing list