[PATCH libnvme] Implement 'dhchap_key' host and controller attributes
Hannes Reinecke
hare at suse.de
Tue Sep 28 05:21:28 PDT 2021
Implement a 'dhchap_key' attribute for the nvme_host structure to
support the 'dhchap_secret' connection argument, and a
'dhchap_key' attribute for the nvme_controller structure to support
the 'dhchap_ctrl_secret' connection argument.
Signed-off-by: Hannes Reinecke <hare at suse.de>
---
pynvme/nvme.i | 2 ++
src/nvme/fabrics.c | 8 +++++++-
src/nvme/json.c | 16 +++++++++++++++-
src/nvme/private.h | 2 ++
src/nvme/tree.c | 43 +++++++++++++++++++++++++++++++++++++++++++
src/nvme/tree.h | 32 ++++++++++++++++++++++++++++++++
6 files changed, 101 insertions(+), 2 deletions(-)
diff --git a/pynvme/nvme.i b/pynvme/nvme.i
index 9193617..eb9e6ef 100644
--- a/pynvme/nvme.i
+++ b/pynvme/nvme.i
@@ -271,6 +271,7 @@ struct nvme_host {
%immutable hostid;
char *hostnqn;
char *hostid;
+ char *dhchap_key;
};
struct nvme_subsystem {
@@ -302,6 +303,7 @@ struct nvme_ctrl {
char *traddr;
char *host_traddr;
char *trsvcid;
+ char *dhchap_key;
char *address;
char *firmware;
char *model;
diff --git a/src/nvme/fabrics.c b/src/nvme/fabrics.c
index ebfc635..62012a0 100644
--- a/src/nvme/fabrics.c
+++ b/src/nvme/fabrics.c
@@ -276,7 +276,7 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr)
{
struct nvme_fabrics_config *cfg = nvme_ctrl_get_config(c);
const char *transport = nvme_ctrl_get_transport(c);
- const char *hostnqn, *hostid;
+ const char *hostnqn, *hostid, *hostkey, *ctrlkey;
bool discover = false;
if (!transport) {
@@ -306,6 +306,8 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr)
discover = true;
hostnqn = nvme_host_get_hostnqn(h);
hostid = nvme_host_get_hostid(h);
+ hostkey = nvme_host_get_dhchap_key(h);
+ ctrlkey = nvme_ctrl_get_dhchap_key(c);
if (add_argument(argstr, "transport", transport) ||
add_argument(argstr, "traddr",
nvme_ctrl_get_traddr(c)) ||
@@ -317,6 +319,10 @@ static int build_options(nvme_host_t h, nvme_ctrl_t c, char **argstr)
nvme_ctrl_get_trsvcid(c)) ||
(hostnqn && add_argument(argstr, "hostnqn", hostnqn)) ||
(hostid && add_argument(argstr, "hostid", hostid)) ||
+ (!discover && hostkey &&
+ add_argument(argstr, "dhchap_secret", hostkey)) ||
+ (!discover && ctrlkey &&
+ add_argument(argstr, "dhchap_ctrl_secret", ctrlkey)) ||
(!discover &&
add_int_argument(argstr, "nr_io_queues",
cfg->nr_io_queues, false)) ||
diff --git a/src/nvme/json.c b/src/nvme/json.c
index 9d49758..83c91ac 100644
--- a/src/nvme/json.c
+++ b/src/nvme/json.c
@@ -94,6 +94,9 @@ static void json_parse_port(nvme_subsystem_t s, struct json_object *port_obj)
c = nvme_lookup_ctrl(s, transport, traddr, host_traddr,
host_iface, trsvcid);
if (c) {
+ attr_obj = json_object_object_get(port_obj, "dhchap_key");
+ if (attr_obj)
+ nvme_ctrl_set_dhchap_key(c, json_object_get_string(attr_obj));
json_update_attributes(c, port_obj);
}
}
@@ -136,6 +139,9 @@ static void json_parse_host(nvme_root_t r, struct json_object *host_obj)
if (attr_obj)
hostid = json_object_get_string(attr_obj);
h = nvme_lookup_host(r, hostnqn, hostid);
+ attr_obj = json_object_object_get(host_obj, "dhchap_key");
+ if (attr_obj)
+ nvme_host_set_dhchap_key(h, json_object_get_string(attr_obj));
subsys_array = json_object_object_get(host_obj, "subsystems");
if (!subsys_array)
return;
@@ -192,6 +198,10 @@ static void json_update_port(struct json_object *ctrl_array, nvme_ctrl_t c)
value = nvme_ctrl_get_trsvcid(c);
if (value)
json_object_add_value_string(port_obj, "trsvcid", value);
+ value = nvme_ctrl_get_dhchap_key(c);
+ if (value)
+ json_object_add_value_string(port_obj, "dhchap_key",
+ value);
JSON_INT_OPTION(cfg, port_obj, nr_io_queues, 0);
JSON_INT_OPTION(cfg, port_obj, nr_write_queues, 0);
JSON_INT_OPTION(cfg, port_obj, nr_poll_queues, 0);
@@ -248,7 +258,7 @@ int json_update_config(nvme_root_t r, const char *config_file)
json_root = json_object_new_array();
nvme_for_each_host(r, h) {
nvme_subsystem_t s;
- const char *hostid;
+ const char *hostid, *dhchap_key;
host_obj = json_object_new_object();
json_object_add_value_string(host_obj, "hostnqn",
@@ -257,6 +267,10 @@ int json_update_config(nvme_root_t r, const char *config_file)
if (hostid)
json_object_add_value_string(host_obj, "hostid",
hostid);
+ dhchap_key = nvme_host_get_dhchap_key(h);
+ if (dhchap_key)
+ json_object_add_value_string(host_obj, "dhchap_key",
+ dhchap_key);
subsys_array = json_object_new_array();
nvme_for_each_subsystem(h, s) {
json_update_subsys(subsys_array, s);
diff --git a/src/nvme/private.h b/src/nvme/private.h
index 2a151bf..803d0ce 100644
--- a/src/nvme/private.h
+++ b/src/nvme/private.h
@@ -77,6 +77,7 @@ struct nvme_ctrl {
char *trsvcid;
char *host_traddr;
char *host_iface;
+ char *dhchap_key;
bool discovered;
bool persistent;
struct nvme_fabrics_config cfg;
@@ -103,6 +104,7 @@ struct nvme_host {
char *hostnqn;
char *hostid;
+ char *dhchap_key;
};
struct nvme_root {
diff --git a/src/nvme/tree.c b/src/nvme/tree.c
index 293b0c0..0910b32 100644
--- a/src/nvme/tree.c
+++ b/src/nvme/tree.c
@@ -147,6 +147,21 @@ const char *nvme_host_get_hostid(nvme_host_t h)
return h->hostid;
}
+const char *nvme_host_get_dhchap_key(nvme_host_t h)
+{
+ return h->dhchap_key;
+}
+
+void nvme_host_set_dhchap_key(nvme_host_t h, const char *key)
+{
+ if (h->dhchap_key) {
+ free(h->dhchap_key);
+ h->dhchap_key = NULL;
+ }
+ if (key)
+ h->dhchap_key = strdup(key);
+}
+
nvme_subsystem_t nvme_first_subsystem(nvme_host_t h)
{
return list_top(&h->subsystems, struct nvme_subsystem, entry);
@@ -310,6 +325,8 @@ static void __nvme_free_host(struct nvme_host *h)
free(h->hostnqn);
if (h->hostid)
free(h->hostid);
+ if (h->dhchap_key)
+ free(h->dhchap_key);
h->r->modified = true;
free(h);
}
@@ -415,6 +432,11 @@ static int nvme_scan_subsystem(struct nvme_root *r, char *name,
free(hostnqn);
if (hostid)
free(hostid);
+ if (h) {
+ if (h->dhchap_key)
+ free(h->dhchap_key);
+ h->dhchap_key = nvme_get_attr(path, "dhchap_secret");
+ }
}
if (!h)
h = nvme_default_host(r);
@@ -666,6 +688,21 @@ struct nvme_fabrics_config *nvme_ctrl_get_config(nvme_ctrl_t c)
return &c->cfg;
}
+const char *nvme_ctrl_get_dhchap_key(nvme_ctrl_t c)
+{
+ return c->dhchap_key;
+}
+
+void nvme_ctrl_set_dhchap_key(nvme_ctrl_t c, const char *key)
+{
+ if (c->dhchap_key) {
+ free(c->dhchap_key);
+ c->dhchap_key = NULL;
+ }
+ if (key)
+ c->dhchap_key = strdup(key);
+}
+
void nvme_ctrl_disable_sqflow(nvme_ctrl_t c, bool disable_sqflow)
{
c->cfg.disable_sqflow = disable_sqflow;
@@ -1035,6 +1072,7 @@ static int nvme_configure_ctrl(nvme_ctrl_t c, const char *path,
c->queue_count = nvme_get_ctrl_attr(c, "queue_count");
c->serial = nvme_get_ctrl_attr(c, "serial");
c->sqsize = nvme_get_ctrl_attr(c, "sqsize");
+ c->dhchap_key = nvme_get_ctrl_attr(c, "dhchap_ctrl_secret");
return 0;
}
@@ -1173,6 +1211,11 @@ nvme_ctrl_t nvme_scan_ctrl(nvme_root_t r, const char *name)
free(hostnqn);
if (hostid)
free(hostid);
+ if (h) {
+ if (h->dhchap_key)
+ free(h->dhchap_key);
+ h->dhchap_key = nvme_get_attr(path, "dhchap_secret");
+ }
if (!h) {
h = nvme_default_host(r);
if (!h) {
diff --git a/src/nvme/tree.h b/src/nvme/tree.h
index 4974741..48f2ad4 100644
--- a/src/nvme/tree.h
+++ b/src/nvme/tree.h
@@ -105,6 +105,21 @@ const char *nvme_host_get_hostnqn(nvme_host_t h);
*/
const char *nvme_host_get_hostid(nvme_host_t h);
+/**
+ * nvme_host_get_dhchap_key() -
+ * @h:
+ *
+ * Return:
+ */
+const char *nvme_host_get_dhchap_key(nvme_host_t h);
+
+/**
+ * nvme_host_set_dhchap_key() -
+ * @h:
+ * @key:
+ */
+void nvme_host_set_dhchap_key(nvme_host_t h, const char *key);
+
/**
* nvme_default_host() -
* @r:
@@ -787,6 +802,23 @@ const char *nvme_ctrl_get_host_traddr(nvme_ctrl_t c);
*/
const char *nvme_ctrl_get_host_iface(nvme_ctrl_t c);
+/**
+ * nvme_ctrl_set_dhchap_key() -
+ * @c:
+ * @key:
+ *
+ * Return:
+ */
+void nvme_ctrl_set_dhchap_key(nvme_ctrl_t c, const char *key);
+
+/**
+ * nvme_ctrl_get_dhchap_key() -
+ * @c:
+ *
+ * Return:
+ */
+const char *nvme_ctrl_get_dhchap_key(nvme_ctrl_t c);
+
/**
* nvme_ctrl_get_config() -
* @c:
--
2.29.2
More information about the Linux-nvme
mailing list