[REGRESSION] nvme: code command_id with a genctr for use-after-free validation crashes apple T2 SSD

[Orlando Chamberlain]

On 26/9/21 13:53, Orlando Chamberlain wrote:
>> Great, that's essentially what I proposed in a different thread (sorry, I see
>> now you were not copied there):
>>
>>   http://lists.infradead.org/pipermail/linux-nvme/2021-September/027665.html
>>
>> The final patch may look a bit different, but it should be okay to test with
>> the one in the link.
>>
> I've tried that patch, it doesn't crash, but /dev/nvme0, /dev/nvme0n1 etc don't show up so
> it doesn't progress past the initramfs. There weren't any errors other than preexisting
> acpi table ones.
> 

The issue was that there's a , instead of a | at the end of the second line here. It works when that is replaced with a |.

-				NVME_QUIRK_SHARED_TAGS },
+				NVME_QUIRK_SHARED_TAGS ,
+				NVME_QUIRK_SKIP_CID_GEN },