[PATCH 2/6] nvme: add CNTRLTYPE definitions for 'identify controller'

[Himanshu Madhani]

> On Sep 21, 2021, at 10:15 AM, Hannes Reinecke <hare at suse.de> wrote:
> 
> Update the 'identify controller' structure to define the missing
> CNTRLTYPE field.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.de>
> ---
> include/linux/nvme.h | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index b7c4c4130b65..ed2428918bca 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -31,6 +31,12 @@ enum nvme_subsys_type {
> 	NVME_NQN_NVME	= 2,		/* NVME type target subsystem */
> };
> 
> +enum nvme_ctrl_type {
> +	NVME_CTRL_IO	= 1,		/* I/O controller */
> +	NVME_CTRL_DISC	= 2,		/* Discovery controller */
> +	NVME_CTRL_ADMIN	= 3,		/* Administrative controller */
> +};
> +
> /* Address Family codes for Discovery Log Page entry ADRFAM field */
> enum {
> 	NVMF_ADDR_FAMILY_PCI	= 0,	/* PCIe */
> @@ -244,7 +250,9 @@ struct nvme_id_ctrl {
> 	__le32			rtd3e;
> 	__le32			oaes;
> 	__le32			ctratt;
> -	__u8			rsvd100[28];
> +	__u8			rsvd100[11];
> +	__u8			cntrltype;
> +	__u8			fguid[16];
> 	__le16			crdt1;
> 	__le16			crdt2;
> 	__le16			crdt3;
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

Looks Good. 

Reviewed-by: Himanshu Madhani <himanshu.madhani at oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering