[PATCH 1/6] nvmet: make discovery NQN configurable

[Chaitanya Kulkarni]

On 9/21/21 8:15 AM, Hannes Reinecke wrote:
> TPAR8013 allows for unique discovery NQNs, so make the discovery
> controller NQN configurable by exposing a subsys attribute
> 'discovery_nqn'.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.de>

Couple of nits to avoid two extra lines and remove the unnecessary
local var, please consider following :-

diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index d80717b9779d..33200dca6a7c 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -1236,10 +1236,7 @@ CONFIGFS_ATTR(nvmet_subsys_, attr_model);
  static ssize_t nvmet_subsys_attr_discovery_nqn_show(struct config_item 
*item,
                         char *page)
  {
-       struct nvmet_subsys *subsys = nvmet_disc_subsys;
-
-       return snprintf(page, PAGE_SIZE, "%s\n",
-                       subsys->subsysnqn);
+       return snprintf(page, PAGE_SIZE, "%s\n", 
nvmet_disc_subsys->subsysnqn);
  }

  static ssize_t nvmet_subsys_attr_discovery_nqn_store(struct 
config_item *item,
@@ -1258,8 +1255,7 @@ static ssize_t 
nvmet_subsys_attr_discovery_nqn_store(struct config_item *item,
                 return -ENOMEM;

         /*
-        * The discovery NQN must be different from
-        * subsystem NQN.
+        * The discovery NQN must be different from subsystem NQN.
          */
         if (!strcmp(subsysnqn, subsys->subsysnqn)) {
                 kfree(subsysnqn);


with that looks good.