[PATCH nvme-cli 1/2] add "State" entry

[Keith Busch]

On Thu, Sep 16, 2021 at 04:57:55PM +0000, Chaitanya Kulkarni wrote:
> On 9/15/21 6:29 AM, chengjike wrote:
> > From: chengjike <jiangtao62 at huawei.com>
> > 
> > Add "State" entry in nvme-print.c
> > 
> > Signed-off-by: chengjike <chengjike.cheng at huawei.com>
> > ---
> >   nvme-print.c | 15 +++++++++------
> >   1 file changed, 9 insertions(+), 6 deletions(-)
> > 
> > diff --git a/nvme-print.c b/nvme-print.c
> > index d321ec0..f2b12c0 100644
> > --- a/nvme-print.c
> > +++ b/nvme-print.c
> > @@ -5647,10 +5647,10 @@ static void nvme_show_list_item(nvme_ns_t n)
> >   	snprintf(format, sizeof(format), "%3.0f %2sB + %2d B", (double)lba,
> >   		l_suffix, nvme_ns_get_meta_size(n));
> >   
> > -	printf("%-21s %-20s %-40s %-9d %-26s %-16s %-8s\n",
> > +	printf("%-21s %-20s %-40s %-9d %-26s %-16s %-8s %-8s\n",
> >   		nvme_ns_get_name(n), nvme_ns_get_serial(n),
> >   		nvme_ns_get_model(n), nvme_ns_get_nsid(n), usage, format,
> > -		nvme_ns_get_firmware(n));
> > +		nvme_ns_get_firmware(n), nvme_ns_get_state(n));
> >   }
> >   
> 
> 
> Where is the definition of the nvme_ns_get_state() ? I didn't find in
> this patch, and your commit log is not helpful at all for the reviewers.

It looks like patch 1 and 2 are reversed.