[PATCH v2 0/3] nvme/mpath: fix missed namespaces in ana state update

Christoph Hellwig hch at lst.de
Mon Sep 13 08:32:07 PDT 2021


On Mon, Sep 13, 2021 at 09:30:20AM -0600, Anton Eidelman wrote:
> Fixed two issues in nvme_update_ana_state() that caused ana_work
> to miss existing namespaces and consequently a failure to update
> the namespace ANA state based on the ANA log page.
> 
> 1) A plain bug: we skipped an nsid in desc->nsids in a certain
>    combination of nsids present and nsids reports in the ANA log,
>    and failed to match this nsid to an existing namespace.
> 2) Unhandled situation when scan_work appended new namespaces to
>    ctrl->namespaces and did not sort the list yet.
>    In such transient state ana_work would fail to match nsids
>    to those new namespaces.
> 
> Both issues potentially caused some namespaces to get stuck
> in an incorrect ANA state, e.g. to never become live.

What are the changes to v1?  That should always go into the cover letter.



More information about the Linux-nvme mailing list