[PATCH] nvme: Fix missing error code in nvme_configure_directives()

[Chaitanya Kulkarni]

On 9/9/21 7:50 AM, Christoph Hellwig wrote:
> On Thu, Sep 09, 2021 at 07:47:39AM -0700, Keith Busch wrote:
>> On Thu, Sep 09, 2021 at 05:50:21PM +0800, Jiapeng Chong wrote:
>>> From: chongjiapeng <jiapeng.chong at linux.alibaba.com>
>>>
>>> The error code is missing in this code scenario, add the error code
>>> '-EINVAL' to the return value 'ret'.
>>>
>>> Eliminate the follow smatch warning:
>>>
>>> drivers/nvme/host/core.c:786 nvme_configure_directives() warn: missing
>>> error code 'ret'.
>>
>> Nak, the code is correct as-is. Returning a negative error for this
>> harmless condition will result in disabling the controller when we can
>> proceed just fine without directives.
> 
> Oh, indeed.  We should probably throw a comment in to make this more
> clear.
> 
> 

hmm, please ignore my reviewed-by tag, I was under the impression that
it was a block layer mandate and it needs BLK_MAX_WRITE_HINTS hints in 
order to use the controller..

Comment is required for sure.