[PATCH 05/10] qla2xxx: edif: Use link event to wake up app

[Himanshu Madhani]

> On Sep 8, 2021, at 2:28 AM, Nilesh Javali <njavali at marvell.com> wrote:
> 
> From: Quinn Tran <qutran at marvell.com>
> 
> Authentication application may be running and in the past
> tried to probe driver (app_start) but unsuccessful. This
> could be due to the bsg layer not ready to service the request.
> On successful link up, driver will use the netlink Link Up
> event to notify app to retry the app_start call.
> 
> In another case, app does not poll for new npiv host. This
> link up event would notify app of the presence of a new SCSI Host.
> 

Missing 

Fixes: 4de067e5df12c ("scsi: qla2xxx: edif: Add N2N support for EDIF”)
Cc: stable at vger.kernel.org

> Signed-off-by: Quinn Tran <qutran at marvell.com>
> Signed-off-by: Nilesh Javali <njavali at marvell.com>
> ---
> drivers/scsi/qla2xxx/qla_init.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 1e4e3e83b5c7..c6b3d0e7489e 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -5335,15 +5335,14 @@ qla2x00_configure_loop(scsi_qla_host_t *vha)
> 			    "LOOP READY.\n");
> 			ha->flags.fw_init_done = 1;
> 
> +			/*
> +			 * use link up to wake up app to get ready for
> +			 * authentication.
> +			 */
> 			if (ha->flags.edif_enabled &&
> -			    !(vha->e_dbell.db_flags & EDB_ACTIVE) &&
> -			    N2N_TOPO(vha->hw)) {
> -				/*
> -				 * use port online to wake up app to get ready
> -				 * for authentication
> -				 */
> -				qla2x00_post_aen_work(vha, FCH_EVT_PORT_ONLINE, 0);
> -			}
> +			    !(vha->e_dbell.db_flags & EDB_ACTIVE))
> +				qla2x00_post_aen_work(vha, FCH_EVT_LINKUP,
> +						      ha->link_data_rate);
> 
> 			/*
> 			 * Process any ATIO queue entries that came in
> -- 
> 2.19.0.rc0
> 

Otherwise 

Reviewed-by: Himanshu Madhani <himanshu.madhani at oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering