[PATCH] fabrics: fix return value of hostnqn_read_file()

Keith Busch kbusch at kernel.org
Tue Sep 7 14:29:20 PDT 2021


On Sun, Sep 05, 2021 at 05:57:19PM -0700, Chaitanya Kulkarni wrote:
> @@ -855,7 +855,7 @@ static char *hostnqn_read_file(void)
>  
>  out:
>  	fclose(f);
> -	return ret;
> +	return strcmp(ret, "") == 0 ? NULL : ret;
>  }

But if the 'goto out' label is used, you are calling strcmp() with a
NULL pointer.

And if "ret" is an emptry string, I think you still need to free() it
here since it is not being returned anymore.



More information about the Linux-nvme mailing list