[PATCH 5/7] nvme: expose subsystem type in sysfs attribute 'subtype'

Christoph Hellwig hch at lst.de
Tue Oct 12 06:10:57 PDT 2021


On Wed, Sep 22, 2021 at 10:02:56AM +0200, Daniel Wagner wrote:
> On Wed, Sep 22, 2021 at 08:35:23AM +0200, Hannes Reinecke wrote:
> > +static SUBSYS_ATTR_RO(subtype, S_IRUGO, nvme_subsys_show_subtype);
> > +
> >  #define nvme_subsys_show_str_function(field)				\
> >  static ssize_t subsys_##field##_show(struct device *dev,		\
> >  			    struct device_attribute *attr, char *buf)	\
> > @@ -2618,6 +2636,7 @@ static struct attribute *nvme_subsys_attrs[] = {
> >  	&subsys_attr_serial.attr,
> >  	&subsys_attr_firmware_rev.attr,
> >  	&subsys_attr_subsysnqn.attr,
> > +	&subsys_attr_subtype.attr,
> 
> 
> Shouldn't this be subsystype to stay consistent with subsysnqn?

Hannes? I've aplied the patch for now, but the above seems like a useful
fixup to fold in.



More information about the Linux-nvme mailing list