[RFC PATCH 8/8] md: add support for REQ_OP_VERIFY

Mike Snitzer snitzer at redhat.com
Fri Nov 12 07:19:33 PST 2021


On Thu, Nov 11 2021 at  3:13P -0500,
Chaitanya Kulkarni <chaitanyak at nvidia.com> wrote:

> On 11/3/2021 11:46 PM, Chaitanya Kulkarni wrote:
> > From: Chaitanya Kulkarni <kch at nvidia.com>
> > 
> > Signed-off-by: Chaitanya Kulkarni <kch at nvidia.com>
> 
> I want to make sure the new REQ_OP_VERIFY is compatible with the
> dm side as it is a generic interface.
> 
> Any comments on the dm side ? It will help me to respin the series for
> V1 of this proposal.

I can review, but have you tested your XFS scrub usecase ontop of
the various DM devices you modified?

Also, you seem to have missed Keith's suggestion of using io_uring to
expose this capability.  If you happen to go that route: making sure
DM has required io_uring capabilities would be needed (IIRC there
were/are some lingering patches from Ming Lei to facilitate more
efficient io_uring on DM.. I'll try to find, could be I'm wrong).

Mike




More information about the Linux-nvme mailing list