[PATCH v2] nvme-tcp: Check if request has started before processing it

Sagi Grimberg sagi at grimberg.me
Wed Mar 31 23:24:49 BST 2021


>> What we can do, though, is checking the 'state' field in the tcp
>> request, and only allow completions for commands which are in a state
>> allowing for completions.
>>
>> Let's see if I can whip up a patch.
> 
> That would be great.  BTW in the crash dump I am looking at now, it
> looks like pdu->command_id was zero in nvme_tcp_recv_data(), and
> blk_mq_tag_to_rq() returned a request struct that had not been used.
> So I think we do need to check that the tag was actually allocated.

request tag can't be zero? I forget...



More information about the Linux-nvme mailing list