[PATCH 1/2] nvme-tcp: check sgl supported by target

[Max Gurtovoy]

On 3/31/2021 4:12 AM, Chaitanya Kulkarni wrote:
> On 3/30/21 17:30, Keith Busch wrote:
>> On Tue, Mar 30, 2021 at 11:01:19PM +0000, Max Gurtovoy wrote:
>>> SGLs support is mandatory for NVMe/tcp, make sure that the target is
>>> aligned to the specification.
>> Logging an error seems fine. Are there existing controllers that do
>> this? If so, what currently happens? If they just have a broken Identify
>> Controller structure but still work with this driver, should we proceed
>> with trying to use it anyway with the existing assumption?
>>   
> At least I've not seen any, in case they do exists should we consider adding
> a quirk if at all any of those controller's start showing up ?
>
I also haven't seen controllers with broken ID-CTRL, and adding a quirk 
in the future is better than ignoring the error and hope for good 
behavior from the controller.