[PATCH] nvme-pci: add another device ID with stripe quirk

[Ye, Jinhe]

Checked P5510 and it supports noiob field. 
nvme id-ns /dev/nvme0n1 |grep noiob
noiob   : 256

The purpose of the patch is for customers who are using old kernels. May I know from which kernel will support "stripe" quirk by noiob field checking? Thank you!

-----Original Message-----
From: Keith Busch <kbusch at kernel.org> 
Sent: Wednesday, March 17, 2021 5:09 AM
To: Christoph Hellwig <hch at infradead.org>
Cc: Zheng, Wu <wu.zheng at intel.com>; linux-nvme at lists.infradead.org; Ye, Jinhe <jinhe.ye at intel.com>
Subject: Re: [PATCH] nvme-pci: add another device ID with stripe quirk

On Tue, Mar 16, 2021 at 07:30:42AM +0000, Christoph Hellwig wrote:
> On Mon, Mar 15, 2021 at 11:22:18PM -0400, Zheng Wu wrote:
> > From: Wu Zheng <wu.zheng at intel.com>
> > 
> > Adds the Intel controller of P5510 which has the "stripe" quirk.
> > 
> > Signed-off-by: Zheng Wu <wu.zheng at intel.com>
> > Signed-off-by: Ye Jinhe <jinhe.ye at intel.com>
> 
> I'm pretty sure we said we're not going add more of these years after 
> there has been a standard way to communicate this performance 
> preference using the noiob field.

P5510 was a Q4'20 release and NOIOB is 4 years older than that!

Jinhe, is it possible to reiterate to the development side how painful this non-standard behavior is to the nvme ecosystem? The spec compliant method is a simple and harmless f/w change that will make all your Linux customers better off.