[PATCH 2/2] nvme: use driver pdu command for passthrough

Sagi Grimberg sagi at grimberg.me
Tue Mar 16 17:44:11 GMT 2021


> -blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
> -		struct nvme_command *cmd)
> +blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
>   {
> +	struct nvme_command *cmd = nvme_req(req)->cmd;
>   	blk_status_t ret = BLK_STS_OK;
>   
>   	if (!(req->rq_flags & RQF_DONTPREP))
>   		nvme_clear_nvme_request(req);
>   
> -	memset(cmd, 0, sizeof(*cmd));

I'm assuming nothing broke with this clearing removed...

Did you happen to run blktests?
- ./check nvme
- nvme_trtype=rdma ./check nvme
- nvme_trtype=tcp ./check nvme



More information about the Linux-nvme mailing list