[PATCH] nvmet-tcp: Fix receive data digest calculation for multiple h2cdata PDUs

[Grupi, Elad]

Sure. I will send new patch shortly.

Elad

-----Original Message-----
From: Sagi Grimberg <sagi at grimberg.me> 
Sent: Tuesday, 16 March 2021 8:30
To: Grupi, Elad; linux-nvme at lists.infradead.org; Christoph Hellwig; Keith Busch; Chaitanya Kulkarni
Subject: Re: [PATCH] nvmet-tcp: Fix receive data digest calculation for multiple h2cdata PDUs


[EXTERNAL EMAIL] 


> Hi Sagi,

Hey Elad,

> Can you please explain why you avoid calling nvmet_tcp_unmap_pdu_iovec on data_digest PDU?
> I don't recall any other case that unmap is being called on good path.

You are correct. We need to either add unmap in the data_digest path here or when completing the data digest reception.. Probably better here.

Care to send a patch or should I?