nvmet_set_error ignores error_loc NVMET_NO_ERROR_LOC

Engel, Amit Amit.Engel at Dell.com
Tue Mar 16 08:57:08 GMT 2021


Hello,
A question regarding Get Log Page - Error Information lid 01h:
According to nvme spec 1.4,  bytes 15:14 refer to 'Parameter Error Location'
"If the error is not specific to a particular command, then this field shall be set to FFFFh"

In the current implementation, nvmet_req_init initializes req->error_loc to NVMET_NO_ERROR_LOC (((u16)-1))
Then nvmet_set_error has this condition:

if (!ctrl || req->error_loc == NVMET_NO_ERROR_LOC)
	return;

means that the error log will not contain errors that don't specify error_loc
is that expected ? 
don't we expect that param_error_location log page field will be set to FFFFh in case there is no other valid req->error_loc ?

Thanks,
Amit Engel
 






More information about the Linux-nvme mailing list