[PATCH 1/1] nvmet: do not allow model_number exceed 40 bytes

Sagi Grimberg sagi at grimberg.me
Mon Mar 15 21:50:20 GMT 2021


>> According to the NVM specifications, the model number size should be
>> 40 bytes (bytes 63:24 of the Identify Controller data structure).
>> Therefore, any attempt to store a value into model_number which
>> exceeds 40 bytes should return an error.
>>
>> Reviewed-by: Max Gurtovoy <mgurtovoy at nvidia.com>
>> Signed-off-by: Noam Gottlieb <ngottlieb at nvidia.com>
> 
> The patch looks good to me, but is this patch not intended for 5.13 ?
> 
> Since for 5.13 we have nvmet_subsys_attr_model_store_locked(), this
> patch uses nvmet_subsys_attr_model_store().
> 
> Is this a fix for 5.12-rc  ?

I think this patch can wait for 5.13 for sure, maybe needs a Fixes
tag to help it get back to stable...



More information about the Linux-nvme mailing list