libnvme questions

[Keith Busch]

On Fri, Mar 12, 2021 at 09:35:14AM -0600, Tony Asleson wrote:
> On 3/10/21 10:43 PM, Chaitanya Kulkarni wrote:
> > Keith,
> > 
> > On 3/10/21 12:56, Keith Busch wrote:
> >>> 3. Any plans on adding functionality for NVMe management interfaces to
> >>> the library, e.g. NVMe Enclosures?
> >> Will be happen to incorporate any features that are in-spec.
> >>
> > 
> > Adding MI support is good idea ? I think it will bloat the basic
> > functionality.
> > 
> > Can we consider adding MI plug-in for it ?
> > 
> 
> IMHO having standards based functionality only in the cli as a plugin
> diminishes the value of the library.  If a developer is required to fork
> & exec the cli for some functionality, just do it for all.
> 
> If the size of libnvme is a concern, MI could be built into a separate
> library from the same source tree that leverages the base libnvme
> library, to allow selective install & use.

The MI support through the in-band admin queue is totally fine to
support here. If a feature is in-spec, then it has a place in this
library.

MI support over smbus is probably out-of-scope, though.