On Wed, Mar 10, 2021 at 11:57:26AM -0800, Keith Busch wrote: > > +static inline u32 nvme_mps_size_to_bytes(u8 size) > +{ Oops, this function should have been named "size_to_sectors()". I will wait for other feedback before considering v2. > + /* XXX: modify if NVME_CTRL_PAGE_SHIFT ever changes */ > + return 1 << (size + 3); > +}