[PATCH V10 3/8] nvmet: add command set supported ctrl cap

[hch at lst.de]

On Wed, Mar 10, 2021 at 07:05:14AM +0000, Chaitanya Kulkarni wrote:
> Christoph,
> 
> On 3/8/21 20:58, Chaitanya Kulkarni wrote:
> > @@ -1174,6 +1185,8 @@ static void nvmet_init_cap(struct nvmet_ctrl *ctrl)
> >  {
> >  	/* command sets supported: NVMe command set: */
> >  	ctrl->cap = (1ULL << 37);
> > +	if (IS_ENABLED(CONFIG_BLK_DEV_ZONED))
> > +		ctrl->cap |= (1ULL << 43);
> >  	/* CC.EN timeout in 500msec units: */
> >  	ctrl->cap |= (15ULL << 24);
> >  	/* maximum queue entries supported: */
> > -- 2.22.1
> 
> I've completed all the changes from your comment except this hunk.
> 
> Based on your commmet it needs to  be merged with patch
> "nvmet: add NVM Command Set Identifier support",
> but since it is based on the BLK_DEV_ZONED I think it should be a part of
> "nvmet: add ZBD over ZNS backend support" patch, any advise?

Just drop the conditional.  There is no harm in just always supporting
multiple command sets, even if only the NVM command set is advertised.