[PATCH V2 2/8] nvme-core: split init identify into helper

[Christoph Hellwig]

I've applied this as-is for now, but here is something that I think we
should fix up:

>  	if (ctrl->apst_enabled && !prev_apst_enabled)
>  		dev_pm_qos_expose_latency_tolerance(ctrl->device);
>  	else if (!ctrl->apst_enabled && prev_apst_enabled)
>  		dev_pm_qos_hide_latency_tolerance(ctrl->device);

I don't think this belongs into init_identify, as it has nothing to do
with the identify data.

> +	ret = nvme_init_identify(ctrl);
> +	if (ret)
> +		return ret;
> +
>  	ret = nvme_configure_apst(ctrl);
>  	if (ret < 0)
>  		return ret;

OTOH it would make a whole lot sense in nvme_configure_apst.