[PATCH 00/10] Some minor fixes/additions for nvme-cli
mwilck at suse.com
mwilck at suse.com
Sat Mar 6 00:36:14 GMT 2021
From: Martin Wilck <mwilck at suse.com>
This series collects patches from my former submission "RFC: add "nvme
monitor" subcommand" which aren't directly related to the monitor
functionality, but required to make the monitor in its current form
compile. A v2 of the monitor code is about to follow soon.
The main part is the "generic logging functionality".
Changes wrt the RFC: add "nvme monitor" subcommand series: many.
- rebased to current upstream code base e9d43dd ("[nvme-cli] Fix Max/Min
User data erase counts displayed in 0xC2 Log Page"))
- renamed log() to msg() in order to prevent name clash with <math.h>
- put logging and cleanup files in "util/" subdirectory
- converted the bulk of the logging code from a macro into a function
(Hannes)
- added functionality to optionally log the PID (default off).
- added Hannes' patch he recently submitted via github
(https://github.com/linux-nvme/nvme-cli/pull/942), with two minor
fixes on top, rationale in the commit messages
- various additional fixes for memory handling
Both cleanup and logging functions / macros could be used in more
places with positive effects, but my focus is currently on preparing
the monitor functionality.
I've pushed this series https://github.com/linux-nvme/nvme-cli/pull/877,
together with the follow-up monitor series.
Regards
Martin
Hannes Reinecke (1):
nvme-discover: lookup existing persistent controllers
Martin Wilck (9):
nvme-discover: assume device given on command line is persistent
do_discover: free cfg.device when resetting it
nvme-connect-all(1): fix documentation for --quiet/-S
nvme: add some simplifying macros for __attribute__((cleanup()))
nvme-cli: add generic logging functionality
nvme: convert some function arguments from "char *" to "const char *"
fabrics: use "const char *" in struct config
fabrics: fix some memory leaks
fabrics: fix invalid memory access in discover_from_conf_file()
Documentation/nvme-connect-all.1 | 8 +-
Documentation/nvme-connect-all.html | 10 +-
Documentation/nvme-connect-all.txt | 4 +-
Makefile | 2 +-
fabrics.c | 223 +++++++++++++++++-----------
nvme-topology.c | 2 +-
nvme.c | 2 +-
nvme.h | 4 +-
util/cleanup.c | 4 +
util/cleanup.h | 18 +++
util/log.c | 90 +++++++++++
util/log.h | 34 +++++
12 files changed, 298 insertions(+), 103 deletions(-)
create mode 100644 util/cleanup.c
create mode 100644 util/cleanup.h
create mode 100644 util/log.c
create mode 100644 util/log.h
--
2.29.2
More information about the Linux-nvme
mailing list