[PATCH 1/3] nvme: fixup kato deadlock

[Hannes Reinecke]

On 3/4/21 9:02 AM, Christoph Hellwig wrote:
> On Wed, Mar 03, 2021 at 03:23:12PM +0100, Hannes Reinecke wrote:
>> Actually, having thought a bit more, I'm not sure if we should change
>> that. Changing the number of reserved commands _will_ have an impact on
>> error recovery, up to the point that we cannot issue a 'connect' command
>> if a keep-alive command is still running.
>> Which means we might be seeing spurious connection failures during
>> recovery, something which I'd be very cautious about.
> 
> We always do a blk_mq_tagset_busy_iter that cancels all requests before
> reconnecting.
> 
Right; and as we're now failing allocations we should be good.
Let's see whether it holds up during testing.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer