[RFC PATCH linux-nvme] ACPI: storage_d3_cpu_ids[] can be static

Limonciello, Mario mario.limonciello at amd.com
Wed Jun 16 08:59:13 PDT 2021


On 6/15/2021 22:22, kernel test robot wrote:
> drivers/acpi/x86/utils.c:153:25: warning: symbol 'storage_d3_cpu_ids' was not declared. Should it be static?
> 
> Fixes: 7c20093d34bc ("ACPI: Add quirks for AMD Renoir/Lucienne CPUs to force the D3 hint")
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: kernel test robot <lkp at intel.com>
> ---
>   utils.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index 5298bb4d81fea..f22f23933063b 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -150,7 +150,7 @@ bool acpi_device_always_present(struct acpi_device *adev)
>    *
>    * This allows quirking on Linux in a similar fashion.
>    */
> -const struct x86_cpu_id storage_d3_cpu_ids[] = {
> +static const struct x86_cpu_id storage_d3_cpu_ids[] = {
>   	X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL),	/* Renoir */
>   	X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL),	/* Lucienne */
>   	{}
> 

Acked-By: Mario Limonciello <mario.limonciello at amd.com>



More information about the Linux-nvme mailing list