[PATCH 0/4] nvme-fabrics: remove struct zeroout memset calls

Chaitanya Kulkarni chaitanya.kulkarni at wdc.com
Mon Jun 14 19:45:50 PDT 2021


Hi,

While reviewing the code I did removed the calls to zero out structures
using memset() for the lio target, which are reviewed and accepted in
the linux kernel tree. (see [1])

This patch series is based on the same cleanup pattern for NVMe host.
This will allow us to have uniform pattern in the future code review to
avoid similar calls which seems unnecessary.

If this is accepted I'll gradually convert the rest of the host code
mainly core and pci.

-ck

Chaitanya Kulkarni (4):
  nvme-fabrics: remove memset in nvmf_reg_read64()
  nvme-fabrics: remove memset in nvmf_reg_write32()
  nvme-fabrics: remove memset in connect admin q
  nvme-fabrics: remove memset in connect io q

 drivers/nvme/host/fabrics.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

[1] https://lore.kernel.org/linux-scsi/20210228055645.22253-1-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-13-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-14-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-15-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-16-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-17-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-18-chaitanya.kulkarni@wdc.com/
https://lore.kernel.org/linux-scsi/20210228055645.22253-19-chaitanya.kulkarni@wdc.com/

-- 
2.22.1




More information about the Linux-nvme mailing list