[PATCH v2 1/4] nvmet: change sn size and check validity

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Mon Jun 7 12:59:24 PDT 2021


On 6/7/21 02:23, Max Gurtovoy wrote:
> From: Noam Gottlieb <ngottlieb at nvidia.com>
>
> According to the NVM specification, the serial_number should be 20 bytes
> (bytes 23:04 of the Identify Controller data structure), and should
> contain only ASCII characters.
>
> In accordance, the serial_number size is changed to 20 bytes and before
> any attempt to store a new value in serial_number we check that the
> input is valid - i.e. contains only ASCII characters, is not empty and
> does not exceed 20 bytes.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy at nvidia.com>
> Signed-off-by: Noam Gottlieb <ngottlieb at nvidia.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>





More information about the Linux-nvme mailing list