[PATCH v3 1/5] blk-mq: introduce blk_mq_set_request_complete

Christoph Hellwig hch at lst.de
Thu Jan 21 03:40:59 EST 2021


On Thu, Jan 21, 2021 at 03:03:26PM +0800, Chao Leng wrote:
> nvme drivers need to set the state of request to MQ_RQ_COMPLETE when
> directly complete request in queue_rq.
> So add blk_mq_set_request_complete.

So I'm not happy with this helper.  It should at least:

 a) be named and documented to only apply for the ->queue_rq faіlure case
 b) check that the request is in MQ_RQ_IDLE state



More information about the Linux-nvme mailing list