[PATCH 2/2] nvme-pci: fix error unwind in nvme_map_data

Christoph Hellwig hch at lst.de
Wed Jan 20 12:56:20 EST 2021


On Thu, Jan 21, 2021 at 02:42:52AM +0900, Keith Busch wrote:
> On Wed, Jan 20, 2021 at 05:48:24PM +0100, Christoph Hellwig wrote:
> > On Wed, Jan 20, 2021 at 07:23:39AM -0800, Marc Orr wrote:
> > > On Wed, Jan 20, 2021 at 1:49 AM Christoph Hellwig <hch at lst.de> wrote:
> > > >
> > > > Properly unwind step by step using refactored helpers from nvme_unmap_data
> > > > to avoid a potential double dma_unmap on a mapping failure.
> > > >
> > > > Reported-by: Marc Orr <marcorr at google.com>
> > > > Signed-off-by: Christoph Hellwig <hch at lst.de>
> > > 
> > > Should these patches go to stable?
> > 
> > Yes.  I've added the proper fixes tag:
> > 
> > Fixes: 7fe07d14f71f ("nvme-pci: merge nvme_free_iod into nvme_unmap_data")
> 
> Patches look good.
> 
> Reviewed-by: Keith Busch <kbusch at kernel.org>
> 
> Just fyi, the 2/2 is the only one with the "Fixes" tag, but it depends
> on 1/2 to compile. It applies cleanly to the recent stables, though, so
> stable bot might have some trouble with it.

patch 2 obviously depends on 1, the bot has been pretty good at
figuring that out.



More information about the Linux-nvme mailing list